This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 7/8] Documentation changes


> Date: Tue, 08 Nov 2011 14:43:18 +0800
> From: Yao Qi <yao@codesourcery.com>
> 
> This patch is about documentation changes to reflect 1) the changes on
> tracepoint behavior, 2) a new remote feature.

Thanks.  A few comments about this part:

>  data, and then allow the program to continue.  Setting a tracepoint or
> -changing its actions doesn't take effect until the next @code{tstart}
> +changing its actions takes effect immediately, which  depends on the
> +remote stub's support of @samp{InstallInTrace} feature

I think you meant something like this:

  Setting a tracepoint or changing its actions takes effect
  immediately if the remote stub supports the @samp{InstallInTrace}
  feature.

>                                                        (see
> +@ref{install tracepoint in tracing})for remote targets.

Please use @pxref here, which does TRT for a cross-reference in
parentheses; @ref doesn't (it needs a comma or a period after the
closing brace; makeinfo will bitch at you if you don't put one or the
other).

> +If remote stub doesn't support @samp{InstallInTrace} feature, all these
                                ^^
"the" is missing here.

Okay with these changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]