This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Run tests in gdb.reverse


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> During reviewing "arm reverse debugging" patch, we realize that tests in
Yao> gdb.reverse are not run in common regression test unless we set some
Yao> variables in board file.

Yao> This patch is to convert variable checking in each reverse test case to
Yao> a proc return value checking, so that gdb.reverse tests will be run on
Yao> targets that support reverse debugging.

Thanks for doing this.

Yao> +proc support_process_record {} {
Yao> +
Yao> +    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {

It seems to me that both of the new procs should include the old check
using target_info as well, just in case.  This will avoid breaking
anybody's existing setup.

Ok with that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]