This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: JIT Reader


> Date: Thu, 03 Nov 2011 22:13:06 +0530
> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> CC: gdb-patches@sourceware.org
> 
> New patches attached.  Fixed the formatting errors, refactored
> jit_reader_try_read_symtab to remove the label and the gotos
> altogether, and fixed a small typo in the docs that I had overlooked.
> Everything else is the same.

Thanks.

> +runtime).  Two new @value{GDBN} commands, @code{jit-reader-load} and
                  ^^^
Please delete "new" here.  The manual is supposed to be time-agnostic ;-)

> +will usually result load @file{@var{libdir}/gdb/@var{reader-name}},

"result" is redundant here, please remove it.

> +@item jit-reader-unload
> +
> +Unload the currently loaded JIT reader.

Please don't leave an empty line between @item in a @table and the
following description.

> +@node Writing JIT Debug Info Readers
> +@subsection Writing JIT Debug Info Readers

@cindex entry (with the same text as the subsection name, just in
lower-case, except "JIT") would be good here.

OK with these changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]