This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: JIT Reader

From: Tom Tromey <tromey at redhat dot com>
To: Sanjoy Das <sanjoy at playingwithpointers dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 03 Nov 2011 08:38:47 -0600
Subject: Re: JIT Reader
References: <4EA9095D.5070408@playingwithpointers.com> <m339e6xtdp.fsf@fleche.redhat.com> <4EB26FF7.1070102@playingwithpointers.com>

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> +  TRY_CATCH(e, RETURN_MASK_ALL)

Missing space.

Sanjoy> +    {
Sanjoy> +      if (target_read_memory (code_entry->symfile_addr, gdb_mem,
Sanjoy> +                              code_entry->symfile_size))
Sanjoy> +        {
Sanjoy> +          status = 0;
Sanjoy> +          goto cleanup;

It is not ok to 'goto' out of a TRY_CATCH.

Tom

Follow-Ups:
- Re: JIT Reader
  - From: Sanjoy Das
- Re: JIT Reader
  - From: Sanjoy Das

References:
- Re: JIT Reader
  - From: Tom Tromey
- Re: JIT Reader
  - From: Sanjoy Das

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]