This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] `info proc ' completion [Re: [PATCH] Implement new `info core mappings' command]
- From: Pedro Alves <pedro at codesourcery dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Wed, 2 Nov 2011 18:30:37 +0000
- Subject: Re: [patch] `info proc ' completion [Re: [PATCH] Implement new `info core mappings' command]
- References: <m3wrbr8olq.fsf@redhat.com> <201110311220.53564.pedro@codesourcery.com> <20111101115405.GA15861@host1.jankratochvil.net>
On Tuesday 01 November 2011 11:54:05, Jan Kratochvil wrote:
> On Mon, 31 Oct 2011 13:20:53 +0100, Pedro Alves wrote:
> > I once wrote a patch for that. /me *looks for it*
>
> Rebased and cleaned up the diff.
>
>
> > The reason I never pushed it is that "info proc" handles
> > more than one keyword at the same time. E.g.,
> > "info proc cmdline cwd" displays both cmdline and cwd
> > info simultaneously. That doesn't work if you have a
> > command per keyword.
>
> I did not know that, the doc does not mention it and such feature is very
> easily "workaroundable", I do not think it can be compared to he inconvenience
> of the current state.
I agree.
> OTOH I do not understand what is it good for when one has shell but if the
> feature is already there...
Yeah...
> + int stat_f = (what == IP_STAT || what == IP_ALL);
Extra space.
> + while (args && isspace (*args))
> + args++;
args = skip_spaces (args);
> + if (args && args[0])
> + error (_("Too many parameters: %s"), args);
--
Pedro Alves