This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] gdb crash in cp_scan_for_anonymous_namespace
- From: Tom Tromey <tromey at redhat dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 20 Oct 2011 13:46:29 -0600
- Subject: Re: [patch] gdb crash in cp_scan_for_anonymous_namespace
- References: <j7ps1q$c1k$1@dough.gmane.org>
>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
Aleksandar> I haven't created a testcase yet (the case I have is quite
Aleksandar> complicated with numerous shared objects involved and a
Aleksandar> core).
I think your change is clearly correct, given the comment before
symbol::symtab:
/* The symbol table containing this symbol. This is the file
associated with LINE. It can be NULL during symbols read-in but it is
never NULL during normal operation. */
Aleksandar> 2011-10-20 Aleksandar Ristovski <aristovski@qnx.com>
Aleksandar> * cp-namespace.c (cp_scan_for_anonymous_namespaces): Changed
Aleksandar> function
Aleksandar> arguments by adding OBJFILE. Instead of getting objfile from
Aleksandar> symbol's symtab, use new argument OBJFILE.
Aleksandar> * cp-support.h (cp_scan_for_anonymous_namespaces): Changed function
Aleksandar> arguments by adding OBJFILE.
Aleksandar> * gdb/dwarf2read.c (new_symbol_full): Change call to
Aleksandar> cp_scan_for_anonymous_namespaces to match new signature.
Aleksandar> * gdb/stabsread.c (define_symbol): Change call to
Aleksandar> cp_scan_for_anonymous_namespaces to match new signature.
Ok.
Tom