This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: patch: solib_break from _r_debug.r_brk
- From: Tom Tromey <tromey at redhat dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 03 Oct 2011 14:12:16 -0600
- Subject: Re: patch: solib_break from _r_debug.r_brk
- References: <j61tbv$l88$1@dough.gmane.org> <4E847A11.6080800@redhat.com> <j61v49$2ee$1@dough.gmane.org> <j621ob$lv5$1@dough.gmane.org>
>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
Aleksandar> + const unsigned ptrsz
Aleksandar> + = builtin_type (target_gdbarch)->builtin_func_ptr->length;
You should use TYPE_LENGTH here, not ->length.
Aleksandar> <date> Aleksandar Ristovski <aristovski@qnx.com>
Aleksandar> * solib-svr4.c (svr4_fetch_solib_break_from_r_debug): New.
Aleksandar> (enable_break): Use new function.
I don't really know much about this area; I think it would be better for
someone else to review the patch. Be sure to ping it weekly. After a
decent interval without replies I will take a stab at it.
Tom