This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: solib_break from _r_debug.r_brk


>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:

Aleksandar> +  const unsigned ptrsz
Aleksandar> +    = builtin_type (target_gdbarch)->builtin_func_ptr->length;

You should use TYPE_LENGTH here, not ->length.

Aleksandar> <date>  Aleksandar Ristovski  <aristovski@qnx.com>
Aleksandar>         * solib-svr4.c (svr4_fetch_solib_break_from_r_debug): New.
Aleksandar>         (enable_break): Use new function.

I don't really know much about this area; I think it would be better for
someone else to review the patch.  Be sure to ping it weekly.  After a
decent interval without replies I will take a stab at it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]