This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR-10034 Bad space handling in set remote exec-file command
- From: Abhijit Halder <abhijit dot k dot halder at gmail dot com>
- To: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Mon, 26 Sep 2011 10:52:05 +0530
- Subject: Re: [PATCH] PR-10034 Bad space handling in set remote exec-file command
- References: <CAOhZP9zCT7iSs9Owi1+eBVHDrGLO8fPj4m62LSwa6FV-g-3FhA@mail.gmail.com>
On Sun, Sep 25, 2011 at 2:21 PM, Abhijit Halder
<abhijit.k.halder@gmail.com> wrote:
> Hi,
>
> In the set remote exec-file command if we provide space at the end of
> the file-name the space is not being cleared. This behaviour is
> inconsistent across similar set commands like set logging file etc. My
> patch will fix that behaviour. Please review this patch.
>
> Further, I have found that there is a function in cli/cli-utils.c
> called remove_trailing_whitespace that never used. In many times we
> have removed trailing spaces and for that inline code is written. In
> my next patch I am planning to modify the remove_trailing_whitespace
> function and use it whenever possible in that. Since that patch will
> be relevant to current fix I am proposing, I have mentioned here that
> point.
>
> Thanks,
> Abhijit Halder
>
Oops! A mistake. Correcting the same.