Re: Integration of timed breakpoints into GDB

[Keith Seitz <keiths at redhat dot com>]

On 09/07/2011 10:42 AM, logitech wrote:

> Further details about the implementation can be found here
> http://www.youtube.com/watch?v=PAFQlxqI7qs&feature=player_embedded#! GDB
> Timed breakpoint
>
> I would highly appreciate comments and feedback from your side regarding the
> same.

Thank you for submitting your new feature patch.

To help facilitate the review of your patch, I urge you to read through 
CONTRIBUTE (found in src/gdb/ or on the gdb web page 
http://sourceware.org/gdb/contribute/ ) and make any necessary changes 
to your contribution mentioned in that file.

Specifically:

- Generate diffs (for source files) using "-up" options, preferably 
against CVS HEAD. Instructions for getting CVS HEAD are on the web page 
at http://sourceware.org/gdb/current/ . No need to send diffs for 
ChangeLogs and generated files (like gdb/configure).

- Read and follow the GNU coding standards. There is more on this on the 
gdb wiki: 
http://sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html . 
There is also Joel's excellent "cheat sheet" at 
http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet .

- You are not listed in MAINTAINERS, do you and/or your company (if 
necessary) have an assignment with the FSF?

- You did not supply any ChangeLog entry(-ies).

- I don't see a test case for this. You should write one. It is mostly a 
cut-n-paste job today. Don't be afraid to ask for help. [Hint: start 
with any simple test in gdb.base that uses prepare_for_testing.]

- This will require additions to documentation and probably a NEWS entry.

Thank you!
Keith