This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory

From: Hui Zhu <teawater at gmail dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches ml <gdb-patches at sourceware dot org>
Date: Tue, 6 Sep 2011 16:21:53 +0800
Subject: Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
References: <CANFwon0RttecHT1BrVx886NC6yCsojHm-MWfr7ttS8=CjoNEzg@mail.gmail.com> <m339hz1i9v.fsf@fleche.redhat.com> <CANFwon0wqsOirAz078-y+ti-WFNHGJ45F_-HfS89ViYM02UDFA@mail.gmail.com> <m3fwl2ebq1.fsf@fleche.redhat.com> <CANFwon1h3fytbmBB5DiXjLt=pa7nt_JTuFhuGDxbVjCS=7FwtQ@mail.gmail.com> <m3k4acaysh.fsf@fleche.redhat.com> <CANFwon3kjh4HBH59BXyM=R451iAozjJjJ1kACg=Jbv607PV6aA@mail.gmail.com> <m3k4a9lc8i.fsf@fleche.redhat.com>

On Fri, Aug 19, 2011 at 22:14, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
> Tom> This test seems odd to me. ?Why does the lvalue-ness of the value
> Tom> matter?
>
>>> I don't understand your means, could you do some explain?
>
> I just don't understand why a check of the VALUE_LVAL is necessary.
> Does something go wrong in the other cases? ?It doesn't seem to me that
> it should.
>
> Tom
>

Got it.

I make a new patch remove the line:
>> +            if ((VALUE_LVAL (val_args[i]) == lval_internalvar
>> +             || VALUE_LVAL (val_args[i]) == not_lval)

Please help me review it.

Thanks,
Hui

2011-09-06  Hui Zhu  <teawater@gmail.com>

	* printcmd.c (ui_printf): Add a handler for TYPE_CODE_ARRAY.

Attachment: fix-v-string.txt
Description: Text document

Follow-Ups:
- Re: [PATCH] printcmd.c (ui_printf): make internalvar string can be printf and eval when inferior cannot alloc memory
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]