This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 3/2] Do not bpstat_clear_actions on throw_exception - async fixes


On Wed, 24 Aug 2011 12:33:46 +0200, Pedro Alves wrote:
> Hmm, I don't understand the "drop the bpstat_clear_actions call"
> part?  Isn't that undoing your last change to the previous patch?

I agree, it was bogus.


> > +      exception_print (gdb_stderr, e);
> 
> ... this one though.  Isn't this bit the only thing missing, and
> the rest would be considered just a cleanup?  What am I missing?

Yes.

It looks like pre-approved, I will check it in with the [patch 2/2].
(Without the gdb.base/commands.exp part.)


Thanks,
Jan


gdb/
2011-08-26  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* inf-loop.c (inferior_event_handler): Add exception_print in
	INF_EXEC_COMPLETE.

--- a/gdb/inf-loop.c
+++ b/gdb/inf-loop.c
@@ -121,6 +121,7 @@ inferior_event_handler (enum inferior_event_type event_type,
 	{
 	  bpstat_do_actions ();
 	}
+      exception_print (gdb_stderr, e);
 
       if (!was_sync
 	  && exec_done_display_p
--- a/gdb/testsuite/gdb.base/commands.exp
+++ b/gdb/testsuite/gdb.base/commands.exp
@@ -740,6 +740,7 @@ proc error_clears_commands_left {} {
     }
     gdb_test_no_output "end" "main commands 2c"
 
+    gdb_test_no_output "set target-async on"
     gdb_run_cmd
     gdb_test "" "\r\nhook-stop1\r\n.*\r\ncmd1\r\nUndefined command: \"errorcommandxy\"\\.  Try \"help\"\\." "cmd1 error"
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]