This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] issues in bcache_xmalloc calls.
- From: Tom Tromey <tromey at redhat dot com>
- To: matt rice <ratmice at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 26 Aug 2011 10:55:58 -0600
- Subject: Re: [PATCH] issues in bcache_xmalloc calls.
- References: <1314350550-15312-1-git-send-email-ratmice@gmail.com>
>>>>> "matt" == matt rice <ratmice@gmail.com> writes:
matt> 2011-08-26 Matt Rice <ratmice@gmail.com>
matt> * solib-sunos.c (allocate_rt_common_objfile): Add missing arguments to
matt> bcache_xmalloc.
matt> * symfile.c (reread_symbols): Remove extra calls to bcache_xmalloc.
Thanks.
matt> + objfile->psymbol_cache = bcache_xmalloc (NULL, NULL);
This one should call psymbol_bcache_init.
The patch is ok with this change.
Not your problem, but I think it is bogus that solib-sunos.c allocates
an objfile on its own like this. This sort of thing should be in
objfiles.c, because the current approach makes it too easy to miss this
code when making changes to objfile.
Tom