This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] c++/12266 (again) [cp_demangled_name_parse_free-4.patch]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 13 Aug 2011 18:51:13 +0200
- Subject: Re: [RFA] c++/12266 (again) [cp_demangled_name_parse_free-4.patch]
- References: <4E31EE1A.5040204@redhat.com> <20110802202825.GA13092@host1.jankratochvil.net> <4E419712.3070709@redhat.com>
On Tue, 09 Aug 2011 22:22:42 +0200, Keith Seitz wrote:
> ChangeLog
> 2011-08-09 Keith Seitz <keiths@redhat.com>
>
> * cp-name-parser.y (struct demangle_info): Remove unused
> member PREV.
> (d_grab): Likewise.
> (allocate_info): Change return type to struct demangle_info *.
> Always allocate a new demangle_info.
> Remove unused PREV pointer.
> (cp_new_demangle_parse_info): New function.
> (cp_demangled_name_parse_free): New function.
> (do_demangled_name_parse_free_cleanup): New function.
> (make_cleanup_cp_demangled_name_parse_free): New function.
> (cp_demangled_name_to_comp): Change return type to
> struct demangle_parse_info *.
> Allocate a new storage for each call.
> (main): Update usage for cp_demangled_name_to_comp
> API change.
> * cp-support.h (struct demangle_parse_info): New structure.
> (cp_demangled_name_to_comp): Update API change for
> return type.
> (cp_new_demangle_parse_info): Declare.
> (make_cleanup_cp_demangled_name_parse_free): New declaration.
> (cp_demangled_name_parse_free): Declare.
> * cp-support.c (cp_canonicalize_string): Update API
> change for cp_demangled_name_to_comp.
> (mangled_name_to_comp): Likewise.
> Return struct demangle_parse_info, too.
> (cp_class_name_from_physname): Update mangled_name_to_comp
> API change.
> (method_name_from_physname): Likewise.
> (cp_func_name): Update API change for cp_demangled_name_to_comp.
> (cp_remove_params): Likewise.
> * python/py-type.c (typy_legacy_template_argument): Likewise.
I find it OK now.
Thanks,
Jan