This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][patch] Make DCACHE_LINE runtime-settable


> Cc: ppluzhnikov@google.com
> Date: Fri, 22 Jul 2011 15:20:25 -0700 (PDT)
> From: ppluzhnikov@google.com (Paul Pluzhnikov)
> 
> Attached patch allows the user to e.g. "set dcache-line-size 4096" and
> drastically reduce the number of round trips.
> 
> I've also added "set dcache-size" just for good measure.
> 
> Not sure whether this needs documentation updates.

It does.  Every command and settable option should be documented in
the manual.  We also add to NEWS a short notice of each such addition.

Thanks.

> +  add_setshow_uinteger_cmd ("dcache-line-size", class_obscure,
> +			    &dcache_line_size, _("\
> +Set dcache line size (in bytes, must be power of 2)."), _("\

You cannot have a comma in the first line of a command's doc string.
That's because commands that show only that first line, like "help"
and "apropos", will stop at the first comma.  See
cli-decode.c:print_doc_line.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]