This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] bfin: swapped args in bfin_extract_return_value?

From: Tom Tromey <tromey at redhat dot com>
To: Matt Rice <ratmice at gmail dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 20 Jul 2011 07:59:17 -0600
Subject: Re: [patch] bfin: swapped args in bfin_extract_return_value?
References: <CACTLOFpa7MrLx-1UTx08qX2Akdm=Ssb+tHHN0GjdFp+U6r9G-A@mail.gmail.com>

>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:

Matt> 2011-07-11  Matt Rice  <ratmice@gmail.com>
Matt>         * bfin-tdep.c (bfin_extract_return_value): Fix swapped
Matt>         arguments to store_unsigned_integer.

I think this change is good, but I don't understand why this function
even calls store_unsigned_integer.  I thought
regcache_cooked_read_unsigned did that for you.

Tom

Follow-Ups:
- Re: [patch] bfin: swapped args in bfin_extract_return_value?
  - From: Yao Qi
- Re: [patch] bfin: swapped args in bfin_extract_return_value?
  - From: Mike Frysinger

References:
- [patch] bfin: swapped args in bfin_extract_return_value?
  - From: Matt Rice

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]