This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] gdb: tests: set remotetimeout to gdb_load_timeout for remote targets
- From: Mike Frysinger <vapier at gentoo dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: toolchain-devel at blackfin dot uclinux dot org, Jie Zhang <jie dot zhang at analog dot com>, gdb-patches at sourceware dot org
- Date: Thu, 30 Jun 2011 20:19:01 -0400
- Subject: Re: [PATCH v3] gdb: tests: set remotetimeout to gdb_load_timeout for remote targets
- References: <1308510312-5512-1-git-send-email-vapier@gentoo.org> <1309389910-30787-1-git-send-email-vapier@gentoo.org> <20110630225430.GF2407@adacore.com>
On Thu, Jun 30, 2011 at 18:54, Joel Brobecker wrote:
>> v3
>> Â Â Â - add comments to new helper funcs
>> Â Â Â - use gdb_test_multiple
>>
>> Âgdb/testsuite/config/monitor.exp | Â 16 +++++++++++++++-
>> Âgdb/testsuite/lib/gdb.exp    Â|  27 +++++++++++++++++++++++++++
>> Â2 files changed, 42 insertions(+), 1 deletions(-)
>
> This version is OK. ÂYou forgot to provide a ChangeLog and I forgot
> to remind you about that....
committed with:
2011-06-30 Jie Zhang <jie.zhang@analog.com>
Mike Frysinger <vapier@gentoo.org>
* config/monitor.exp (get_remotetimeout, set_remotetimeout): New
helper functions for getting/setting remotetimeout variable.
* lib/gdb.exp (gdb_load): If the target is remote, set
$oldremotetimeout to get_remotetimeout, then call set_remotetimeout
with $loadtimeout. Set $load_ok to 0 before doing the load.
Instead of returning, immediately, set $load_ok to 0. Call
set_remotetimeout with $oldremotetimeout, and then return if
$load_ok is 1.
-mike