This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] sim: export cb_get_string for people to use
- From: Tom Tromey <tromey at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Fri, 27 May 2011 12:24:08 -0600
- Subject: Re: [PATCH 1/2] sim: export cb_get_string for people to use
- References: <1306438878-14479-1-git-send-email-vapier@gentoo.org>
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> The common sim code provides a useful "get_string" function which reads
Mike> a C string out of the target's memory space. So rename and export it
Mike> for other people to use.
I don't know enough about sim to say whether callback.h is the right
place for this. I would appreciate comments on this.
One nit:
Mike> +int cb_get_string PARAMS ((host_callback *, CB_SYSCALL *, char *, int,
Mike> + unsigned long));
Don't use PARAMS.
Tom