This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove code handling old ARM aliases from GDB


On Wed, 4 May 2011, Joseph S. Myers wrote:

> sim/testsuite:
> 2011-05-04  Joseph Myers  <joseph@codesourcery.com>
>
> 	* configure: Regenerate.
> 	* sim/arm/allinsn.exp (xscale*-*-*): Don't handle target.
> 	* sim/arm/misc.exp (thumb*-*-*, xscale*-*-*): Don't handle
> 	targets.
> 	* sim/arm/iwmmxt/iwmmxt.exp: Test for arm*-*-* instead of
> 	xscale*-*-*.
> 	* sim/arm/thumb/allthumb.exp (thumb*-*-*): Don't handle target.
> 	* sim/arm/xscale/xscale.exp: Test for arm*-*-* instead of
> 	xscale*-*-*.

> Index: sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp
> ===================================================================
> RCS file: /cvs/src/src/sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp,v
> retrieving revision 1.1
> diff -u -r1.1 iwmmxt.exp
> --- sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp	1 Apr 2003 11:07:58 -0000	1.1
> +++ sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp	4 May 2011 18:52:03 -0000
> @@ -1,6 +1,6 @@
>  # Intel(r) Wireless MMX(tm) technology simulator testsuite.
>
> -if { [istarget xscale*-*-*] } {
> +if { [istarget arm*-*-*] } {
>      # load support procs (none yet)
>      # load_lib cgen.exp

> Index: sim/testsuite/sim/arm/xscale/xscale.exp
> ===================================================================
> RCS file: /cvs/src/src/sim/testsuite/sim/arm/xscale/xscale.exp,v
> retrieving revision 1.1
> diff -u -r1.1 xscale.exp
> --- sim/testsuite/sim/arm/xscale/xscale.exp	1 Apr 2003 11:07:58 -0000	1.1
> +++ sim/testsuite/sim/arm/xscale/xscale.exp	4 May 2011 18:52:03 -0000
> @@ -1,6 +1,6 @@
>  # XSCALE simulator testsuite.
>
> -if { [istarget xscale*-*-*] } {
> +if { [istarget arm*-*-*] } {
>      # load support procs (none yet)
>      # load_lib cgen.exp

How did you test these changes?

These changes broke testing for arm-elfo, on ang x86_64 host
using current binutils CVS like so:

Schedule of variations:
    arm-sim

Running target arm-sim
Using /usr/share/dejagnu/baseboards/arm-sim.exp as board description file for target.
Using /usr/share/dejagnu/config/sim.exp as generic interface file for target.
Using /usr/share/dejagnu/baseboards/basic-sim.exp as board description file for target.
Using /tmp/hpautotest-sim/src/sim/testsuite/config/default.exp
as tool-and-target-specific interface file.
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/allinsn.exp ...
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/iwmmxt/iwmmxt.exp ...
FAIL: xscale wcmpgt.cgs (execution)
FAIL: xscale wmac.cgs (execution)
FAIL: xscale wsra.cgs (execution)
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/misc.exp ...
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/thumb/allthumb.exp ...
Running /tmp/hpautotest-sim/src/sim/testsuite/sim/arm/xscale/xscale.exp ...
WARNING: program timed out.
FAIL: xscale blx.cgs (execution)

Please fix, suggesting by adding needed options to the assembler
and sim invocations.  I don't know if src/sim can handle
whatever is tested by iwmmxt.exp and xscale.exp, but if it can't
at all (i.e. these tests are not intended to be run with src/sim
but with real hw or qemu), an alternative would be to
sufficiently gate the tests.  If all else fails, reverting your
change is an option.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]