This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Typedef'd method parameters [1/4]
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 25 Apr 2011 14:22:13 -0600
- Subject: Re: [RFA] Typedef'd method parameters [1/4]
- References: <4DB09E71.305@redhat.com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> As I mentioned in the preamble for this patchset, this patch
Keith> changes cp-name-parser.y to not use shared memory. This is
Keith> accomplished by changing the return type of
Keith> cp_demangled_name_to_comp to return a pointer to a structure
Keith> which contains the relevant storage bits.
It took me a while to understand this since for some reason I was
thinking your patch was going to make the parser reentrant. But of
course we don't need that -- we just need to be able to call the parser
twice and have both results remain valid.
Keith> I have not bothered with storing the error messages: one error
Keith> and the whole thing bows out anyway. Well, that and not a single
Keith> caller actually ever uses it. [Future cleanup to remove *errmsg
Keith> from cp-name-parser.y?]
Having the error seems handy; but the current formatting code for the
error (using snprintf) leaves something to be desired.
Keith> Comment/questions/concerns?
This is ok.
Tom