This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Tue, 19 Apr 2011 12:41:34 +0200
- Subject: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c
Still trying to reduce the number of files appearing in ARI list.
To avoid both operator at end of line and stay below 80-column limit,
I had to use another formatting option for the third parameter of
regcache_cooked_write_unsigned function call:
As the parameter is aa long function call with multiple parameters,
I just indented it with 2 spaces relative to regcache_cooked_write_unsigned
start.
Is this type of indentation OK?
Pierre Muller
GDB pascal language maintainer
2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
* xstormy16-tdep.c (xstormy16_push_dummy_call): Avoid == at end of
line as this is against GNU coding standards.
Index: xstormy16-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v
retrieving revision 1.114
diff -u -p -r1.114 xstormy16-tdep.c
--- xstormy16-tdep.c 18 Mar 2011 18:52:32 -0000 1.114
+++ xstormy16-tdep.c 19 Apr 2011 10:35:47 -0000
@@ -264,11 +264,9 @@ xstormy16_push_dummy_call (struct gdbarc
val = value_contents (args[i]);
for (j = 0; j < typelen; j += xstormy16_reg_size)
regcache_cooked_write_unsigned (regcache, argreg++,
- extract_unsigned_integer (val + j,
- typelen - j ==
- 1 ? 1 :
- xstormy16_reg_size,
- byte_order));
+ extract_unsigned_integer (val + j,
+ typelen - j == 1 ? 1 :
xstormy16_reg_size,
+ byte_order));
}
/* Align SP */