This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA-v2] xtensa-tdep.c ARI fixes

From: Maxim Grigoriev <maxim at tensilica dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Fri, 15 Apr 2011 11:37:20 -0700
Subject: Re: [RFA-v2] xtensa-tdep.c ARI fixes
References: <15837.6740910628$1302342165@news.gmane.org> <m34o60fuc2.fsf@fleche.redhat.com> <37948.3434990563$1302853234@news.gmane.org> <m3aafrcr4d.fsf@fleche.redhat.com>

I tested the patch. No problems have been detected.
Thanks much for improving Xtensa code.

-- Maxim

On 04/15/2011 11:21 AM, Tom Tromey wrote:

"Pierre" == Pierre Muller<pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre>    Here is a new version that adds this xfree call.
Pierre>  Could someone test this patch out?
Pierre>  Again, I have no way to trigger that code, so I can't really test it.
The patch looks good to me.
But I agree, testing would be nice.
Pierre> + && (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);

Extra space after the "&&" :-)

Tom

Follow-Ups:
- RE: [RFA-v2] xtensa-tdep.c ARI fixes
  - From: Pierre Muller

References:
- Re: [RFA] xtensa-tdep.c ARI fixes
  - From: Tom Tromey
- Re: [RFA-v2] xtensa-tdep.c ARI fixes
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]