This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
2011/3/23 Pedro Alves <pedro@codesourcery.com>: > On Wednesday 23 March 2011 14:07:01, Kai Tietz wrote: >> @@ -1023,12 +1025,13 @@ elfstab_offset_sections (struct objfile >> ? ?struct stab_section_info *maybe = dbx->stab_section_info; >> ? ?struct stab_section_info *questionable = 0; >> ? ?int i; >> - ?char *p; >> + ?const char *p; >> >> ? ?/* The ELF symbol info doesn't include path names, so strip the path >> ? ? ? (if any) from the psymtab filename. ?*/ >> - ?while (0 != (p = strchr (filename, '/'))) >> - ? ?filename = p + 1; >> + ?p = lbasename (filename); >> + ?if (p != filename) >> + ? ?filename = p; > > These three lines are the same as just: > > ?filename = lbasename (filename); > > You can then drop the unnecessary `p' local. > > The patch looked good to me with that change. > > -- > Pedro Alves > Thanks for the detailed review. Attached updated patch attached. 2011-03-23 Kai Tietz * breakpoint.c (clear_command): Use filename_cmp instead of strcmp for comparison. * buildsym.c (watch_main_source_file_lossage): Likewise. (patch_subfile_names): Use IS_DIR_SEPARATOR instead of checking just for slash. * dbxread.c (read_dbx_symtab): Use lbasename instead of strrchr and filename_cmp instead of strcmp for filenames. (add_old_header_file): Use filename_cmp instead of strcmp for comparison. * exec.c (exec_set_section_address): Likewise. * macrotab.c (macro_lookup_inclusion): Likewise. (macro_lookup_inclusion): Likewise. * elfread.c (_initialize_elfread): Likewise. (elfstab_offset_sections): Likewise. (elfstab_offset_sections): Use lbasename instead of strrchr. * mdebugread.c (parse_partial_symbols): Likewise. (arse_partial_symbols): Use filename_(n)cmp instead of str(n)cmp for comparison. * minsyms.c (lookup_minimal_symbol): Likewise. * psymtab.c (read_psymtabs_with_filename): Likewise. * solib.c (solib_read_symbols): Likewise. (reload_shared_libraries_1): Likewise. * symmisc.c (maintenance_print_symbols): Likewise. * symfile.c (separate_debug_file_exists): Likewise. (reread_symbols): Likewise. (find_separate_debug_file_by_debuglink): Likewise. * remote-fileio.c (remote_fileio_func_rename): Likewise. * source.c (add_path): Likewise. * symtab.c (filename_seen): Likewise. (file_matches): Likewise. (print_symbol_info): Likewise. (maybe_add_partial_symtab_filename): Likewise. (make_source_files_completion_list): Likewise. * xml-syscall.c (init_sysinfo): Likewise. * windows-nat.c (_initialize_check_for_gdb_ini): Use IS_DIR_SEPARATOR for checking for trailing path separator. Regards, Kai
Attachment:
gdb_filename.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |