This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 3/7] find_pc_partial_function new parameter
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 21 Mar 2011 14:11:03 -0600
- Subject: Re: [patch 3/7] find_pc_partial_function new parameter
- References: <20110319211544.GD30867@host1.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> find_pc_partial_function is heavily called inside GDB, therefore I
Jan> did not change its prototype and provided
Jan> find_pc_partial_function_gnu_ifunc instead.
Jan> While I have no problem with changing all the callers it means passing
Jan> everywhere the unused additional NULL parameter which may not be a win.
This approach is fine. It is already used in many places in GDB.
This patch looked fine to me.
Tom