This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] [patch] Fix PR/12183
- From: Tom Tromey <tromey at redhat dot com>
- To: pmuldoon at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 21 Mar 2011 09:47:40 -0600
- Subject: Re: [python] [patch] Fix PR/12183
- References: <m3hbawr6ax.fsf@redhat.com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> This patch fixes PR python/12183. In this case GDB was printing a
Phil> stack trace for a gdb.GdbError. This is incorrect, GdbErrors
Phil> should not produce a stack trace. This fix is largely a duplicate
Phil> of the code already in py-cmd.
Phil> OK?
Looks good, just one nit.
Phil> + if (! result)
We decided not to put a space after '! 'here.
Phil> + if (! PyErr_GivenExceptionMatches (ptype, gdbpy_gdberror_exc)
And likewise.
Ok with this fixed.
Tom