This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] [patch] Add is_valid to several classes
- From: Tom Tromey <tromey at redhat dot com>
- To: pmuldoon at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 16 Mar 2011 10:42:45 -0600
- Subject: Re: [python] [patch] Add is_valid to several classes
- References: <m3sjun9hp7.fsf@redhat.com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> @@ -85,6 +110,8 @@ objfpy_get_printers (PyObject *o, void *ignore)
Phil> {
Phil> objfile_object *self = (objfile_object *) o;
Phil> + OBJFPY_REQUIRE_VALID (self);
This changes behavior. It is harmless (but goofy) to get or set the
printers on an invalid Objfile.
So, I think this should not be added.
Phil> @@ -95,6 +122,8 @@ objfpy_set_printers (PyObject *o, PyObject *value, void *ignore)
Phil> PyObject *tmp;
Phil> objfile_object *self = (objfile_object *) o;
Phil> + OBJFPY_SET_REQUIRE_VALID (self);
Likewise.
Then you don't need the new macros, either.
The rest looks good to me.
Tom