This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] dbxread.c (process_one_symbol): Assert 'name' is not null.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 15 Mar 2011 09:21:05 -0700
- Subject: Re: [RFA] dbxread.c (process_one_symbol): Assert 'name' is not null.
- References: <4D716C06.3010308@vmware.com>
> There's at least one path to here in which 'name' may be suspected
> of being null.
[...]
> 2011-03-04 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
>
> * dbxread.c (process_one_symbol): Assert 'name' is not null.
I'm not completely sure, and I don't look at this code much anymore
(thank the gods :-), but an assert failure rather than a SEGV sounds
like progress to me. So OK.
I did look at the code and try to reason a bit, and wondered whether
we might want to change the code to:
if (name && name[0] == '#')
instead of adding an assert. But that would potentially change
the behavior, so I'm even less sure. I think we should look at that
the day we actually trigger the assertion.
--
Joel