This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: bfin: decode ASTAT on failure


> 2011-03-14  Robin Getz  <robin.getz@analog.com>
> 
> 	* bfin-sim.c (astat_names): New global bit array.
> 	(decode_CC2stat_0): Delete local astat_name and astat_names.
> 	(decode_psedodbg_assert_0): Move hardcoded offset into a variable.
> 	Print out ASTAT bit values when checking an ASTAT register.

Ok, with just a minor comment:

> +static const char * const astat_names[] = {

The curly brace should be on the next line...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]