This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] python/py-breakpoint.c (bppy_set_condition): Stop memory leak.
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 11 Mar 2011 14:43:58 -0700
- Subject: Re: [RFA] python/py-breakpoint.c (bppy_set_condition): Stop memory leak.
- References: <4D7A944E.20801@vmware.com>
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> 2011-03-11 Michael Snyder <msnyder@vmware.com>
Michael> * python/py-breakpoint.c (bppy_set_condition): Stop memory leak.
This isn't sufficient to stop the leak.
Michael> GDB_PY_SET_HANDLE_EXCEPTION (except);
This can return.
We aren't really using cleanups in "pure python" functions like this one.
You can just explicitly xfree `exp' after the TRY_CATCH.
However, note the `exp = ""' branch.
Tom