This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I am surprised I missed it. Thanks for noticing this. This patch corrects the style violation mentioned by Joel.
2011-03-10 Maxim Grigoriev<maxim2405@gmail.com>Small comments, seen while scanning your patch...
* xtensa-tdep.c (windowing_enabled): Remove inline attribute.
(xtensa_write_register, xtensa_read_register): Likewise.
(xtensa_hextochar): Removed.
(xtensa_init_reggroups): Replace xtensa_hextochar () by explicit code.
-static inline void warning_once ()
+static void warning_once ()
The function name should be on the first column of the line. This is to facilitate the search of the function implementation (we can use:<<grep "^warning_once">> for instance). Also, functions with no arguments should be declared with a "void" parameter. Thus:
static void warning_once (void)
Attachment:
Style.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |