This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: lazily call save_current_space_and_thread


On Tuesday 08 March 2011 16:51:56, Tom Tromey wrote:
> +         /* If we naively call get_selected_frame here, then we can
> +            end up reading debuginfo for the current frame, even
> +            though the user has not selected a frame and we don't
> +            actually need the debuginfo at this point.  */
> +         frame = get_selected_frame_if_set ();

The comment doesn't seem to make much sense as is.  I think
that when the user has the prompt, selected_frame is not going
to be NULL, as normal_stop does:

  select_frame (get_current_frame ());

I think the case at hand is while we're handling internal
events, before giving the prompt to the user.  Is that so?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]