This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: change "program exited" message
On Friday 04 March 2011 19:23:03, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> Pedro> (Do we actually need gdb_continue_off_end? It seemed
> Pedro> like in all but a couple of cases it was the same
> Pedro> as gdb_continue_to_end, except that the new function
> Pedro> doesn't handle using stubs.)
>
> I was not sure that this was safe to do.
It is. You'd even be fixing testsuite hangs and
timeouts for targets that require the stubs, as with
those you'll never see the "exited normally" message.
(I don't think I ever saw such a target though. Still.)
> --- a/gdb/testsuite/gdb.base/langs.exp
> +++ b/gdb/testsuite/gdb.base/langs.exp
> @@ -146,8 +146,7 @@ if [runto csub] then {
> gdb_breakpoint "exit"
> gdb_test "cont" "Breakpoint .*exit.*" "continue to exit in langs.exp"
> } else {
> - gdb_test "cont" "Program exited normally\\..*" \
> - "continue to exit in langs.exp"
> + gdb_continue_off_end
> }
> }
>
This whole if/then/else could be replaced with
gdb_continue_to_end even, it looks like it's just
like just an inlining of the same thing.
> If you think it is ok, I can make that change.
--
Pedro Alves