This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?
- From: Michael Snyder <msnyder at vmware dot com>
- To: nickc at redhat dot com, bug-binutils at gnu dot org, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 03 Mar 2011 11:12:34 -0800
- Subject: [RFA] coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error?
If rel-r_type is equal to ARRA_SIZE, it will overflow the array.
What say you?
2011-03-03 Michael Snyder <msnyder@vmware.com>
* coff-x86_64.c (coff_amd64_rtype_to_howto): Fencepost error.
Index: coff-x86_64.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-x86_64.c,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 coff-x86_64.c
--- coff-x86_64.c 31 Mar 2010 16:32:02 -0000 1.12
+++ coff-x86_64.c 3 Mar 2011 19:07:58 -0000
@@ -546,7 +546,7 @@ coff_amd64_rtype_to_howto (bfd *abfd ATT
{
reloc_howto_type *howto;
- if (rel->r_type > ARRAY_SIZE (howto_table))
+ if (rel->r_type >= ARRAY_SIZE (howto_table))
{
bfd_set_error (bfd_error_bad_value);
return NULL;