This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix magic number in arm-tdep.c


Tom Tromey wrote:
"Michael" == Michael Snyder <msnyder@vmware.com> writes:

-		nextpc = (rn == 15) ? pc_val + 8
+		nextpc = (rn == ARM_PC_REGNUM) ? pc_val + 8
: get_frame_register_unsigned (frame, rn);
(? and : should remain in the same column).


Michael> I don't agree - : is an operator and should be indented by just Michael> two spaces. As emacs does by default.

You're supposed to add extra parens to make it line up.
See the "Formatting" node in the GNU Standards.

Tom

OK, that would suit me. ;-)



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]