This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 01 Mar 2011 12:47:00 -0800
- Subject: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
If frame is null, we will have crashed already from dereferencing it.
2011-03-01 Michael Snyder <msnyder@vmware.com>
* std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.
Index: std-regs.c
===================================================================
RCS file: /cvs/src/src/gdb/std-regs.c,v
retrieving revision 1.31
diff -u -p -u -p -r1.31 std-regs.c
--- std-regs.c 1 Jan 2011 15:33:16 -0000 1.31
+++ std-regs.c 1 Mar 2011 20:42:48 -0000
@@ -70,11 +70,8 @@ value_of_builtin_frame_pc_reg (struct fr
struct value *val = allocate_value (func_ptr_type);
gdb_byte *buf = value_contents_raw (val);
- if (frame == NULL)
- memset (buf, 0, TYPE_LENGTH (value_type (val)));
- else
- gdbarch_address_to_pointer (gdbarch, func_ptr_type,
- buf, get_frame_pc (frame));
+ gdbarch_address_to_pointer (gdbarch, func_ptr_type,
+ buf, get_frame_pc (frame));
return val;
}
}