This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: msnyder at vmware dot com
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 1 Mar 2011 09:49:00 +0100 (CET)
- Subject: Re: [commit] fork-child.c, fork_inferior: Delete ifdef'd code and unused variable.
- References: <4D6C437F.3030700@vmware.com>
> Date: Mon, 28 Feb 2011 16:53:19 -0800
> From: Michael Snyder <msnyder@vmware.com>
>
> checked in.
>
> 2011-02-28 Michael Snyder <msnyder@vmware.com>
>
> * fork-child.c (fork_inferior): Remove ifdef'd code and
> unused variable.
>
> Index: fork-child.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/fork-child.c,v
> retrieving revision 1.61
> diff -u -p -u -p -r1.61 fork-child.c
> --- fork-child.c 11 Jan 2011 15:10:01 -0000 1.61
> +++ fork-child.c 1 Mar 2011 00:50:41 -0000
> @@ -367,12 +367,11 @@ fork_inferior (char *exec_file_arg, char
> /* Otherwise, we directly exec the target program with
> execvp. */
> int i;
> - char *errstring;
>
> execvp (exec_file, argv);
>
> /* If we get here, it's an error. */
> - errstring = safe_strerror (errno);
> + safe_strerror (errno);
Wait a moment! That safe_strerror() call is pretty much a no-op now.
I'm sure whoever wrote that code intended to actually display the
error string.