This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] objc-lang.c, classes_info, avoid string overrun


On 03/01/2011 09:46 AM, Michael Snyder wrote:
> -	  if (sizeof (myregexp) < strlen (regexp) + 1)
> +	  if (sizeof (myregexp) < strlen (regexp) + 4)
>  	    error (_("Regexp is too long: %s"), regexp);
>  	  strcpy(myregexp, regexp);

It is a little bit confusing when people read this code.  We may need a
short comment here.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]