This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Move common macros to i386-common.h

From: Joel Brobecker <brobecker at adacore dot com>
To: Yao Qi <yao at codesourcery dot com>
Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
Date: Thu, 17 Feb 2011 10:36:41 +0400
Subject: Re: [patch] Move common macros to i386-common.h
References: <4D57AB12.1050708@codesourcery.com> <b33d43012c8963212a80ea9180a7dba2.squirrel@webmail.xs4all.nl> <4D5CBF2D.9020101@codesourcery.com>

> w.r.t this specific patch, its "potential benefit" is that, some
> duplicated functions (i386_length_and_rw_bits, and
> i386_{insert|remove}_aligned_watchpoint) in i386-nat.c and
> gdbserver/i386-low.c can be merged together.  Please take this into account.

Thinking beyond that, I think that GDB should conceptualy contain
a internal GDBserver. That way, when we port GDB to an architecture,
we're pretty much porting GDBserver as well, for free. And when
someone only ported GDBserver at one point, we don't need to redo
that work when porting GDB itself.

-- 
Joel

Follow-Ups:
- Re: [patch] Move common macros to i386-common.h
  - From: Jan Kratochvil

References:
- [patch] Move common macros to i386-common.h
  - From: Yao Qi
- Re: [patch] Move common macros to i386-common.h
  - From: Mark Kettenis
- Re: [patch] Move common macros to i386-common.h
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]