This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove ${objdir} from test messages
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Mon, 07 Feb 2011 11:37:39 -0200
- Subject: Re: [RFA] Remove ${objdir} from test messages
- References: <1296857287.3204.10.camel@hactar> <20110206071636.GO2384@adacore.com>
On Sun, 2011-02-06 at 11:16 +0400, Joel Brobecker wrote:
> > 2011-02-04 Thiago Jung Bauermann <bauerman@br.ibm.com>
> >
> > * gdb.base/break-interp.exp: Remove ${objdir} from test messages.
> > * gdb.base/jit.exp: Likewise.
> > * gdb.base/pie-execl.exp: Likewise.
> > * gdb.base/solib-nodir.exp: Likewise.
> > * gdb.base/solib-overlap.exp: Likewise.
>
> This is OK. I would have probably done things a little differently,
> as I don't think it really matters that the test label says exactly
> what command was sent, as long as it's descriptive and unique. So
> I would have probably chosen things like "set args $binfile_test"...
> But since you've done it this way, no need to spend even more time
> on this...
I'm not very familiar with the testcases, so I chose to preserve as much
of the original output as possible. Thanks for the review!
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center