This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA/commit/doco] move handing of "set interactive-mode" to gdb_has_a_terminal
Hi Joel,
I think your patch is good, but
it has an error:
in gdb_has_a_terminal function:
+ if (interactive_mode != AUTO_BOOLEAN_AUTO)
+ return interactive_mode = AUTO_BOOLEAN_TRUE;
+
The current code sets interactive_mode variable
to AUTO_BOOLEAN_TRUE, which happens to be zero,
and thus the function returns 0...
I suppose that the correct code should be:
+ if (interactive_mode != AUTO_BOOLEAN_AUTO)
+ return (interactive_mode == AUTO_BOOLEAN_TRUE);
+
There is also a small error in the ChangeLog:
> > (gdb_has_a_terminal): Add handling of the "iteractive-mode"
This should have "interactive-mode" instead of "iteractive-mode"
Pierre Muller
GDB pascal language maintainer