Re: [patch] Add tests for JIT debugging interface

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Wed, Jan 19, 2011 at 11:03 AM, Pedro Alves <pedro@codesourcery.com> wrote:

>> > Cannot remove breakpoints because program is no longer writable. <-- [1]
>>
>> And that.
>
> It's output from infrun.c:normal_stop. ?Sounds like a bug somewhere.

It is a bug. Fix in progress...

>> That's alright -- I was going to fix this area (see "JIT interface
>> slowness" in gdb@sourceware.org list), and this isn't the only problem --
>> I also noticed that we leak several jit_breakpoints on rerun.

That leak is in fact causing the bug above ...

>> +int main (int argc, char *argv[])
>> +{
>> + ?/* These variables are here so they can easily be set from jit.exp ?*/
>
> "main" at column 0. ?Period, double space.

Fixed.

>> +gdb_exit
>> +gdb_start
>> +gdb_reinitialize_dir $srcdir/$subdir
>> +gdb_load $binfile
>
> gdb_load_shlibs call missing. ?This will probably need tweaking for
> remote host testing, but we'll handle it when/if we stumble on it
> on our testing, probably.
>
> Did you try Yao's suggestion of using clean_restart/prepare_for_testing, etc.?
> We're prefering using those whenever possible.

I am already doing clean_restart inside one_jit_test.  Above were unnecessary
leftovers.  Deleted.

prepare_for_testing rebuilds the executable, which is not necessary here;
so not using that.


Thanks!
-- 
Paul Pluzhnikov

2011-01-19  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* gdb.base/jit.exp: New file.
	* gdb.base/jit-main.c: New file.
	* gdb.base/jit-solib.c: New file.

Attachment: gdb-jit-tests-20110119.txt
Description: Text document