This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ping] Re: [rfc/rfa v2] Use ARM exception tables as GDB unwinder
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: dan at codesourcery dot com (Daniel Jacobowitz), rearnsha at arm dot com
- Cc: gdb-patches at sourceware dot org, matthew dot gretton-dann at arm dot com
- Date: Tue, 11 Jan 2011 18:26:20 +0100 (CET)
- Subject: [ping] Re: [rfc/rfa v2] Use ARM exception tables as GDB unwinder
Daniel Jacobowitz wrote:
> On Wed, Dec 01, 2010 at 05:07:37PM +0100, Ulrich Weigand wrote:
> > - We now only trust ARM unwind info at call sites, not at arbitrary
> > PC locations. (Note that we consider system calls to be call sites
> > as well for this purpose, see the comment in the code.)
>
> That's a clever compromise; I like it. We lose a bit with
> asynchronous signals, but it's a very small bit since you consider
> system calls as call sites too.
>
> > @@ -1899,6 +1909,744 @@ struct frame_unwind arm_prologue_unwind
> > default_frame_sniffer
> > };
> >
> > +/* Maintain a list of ARM exception table entries per objfile, similar to the
> > + list of mapping symbols. We only cache entries for standard ARM-defined
> > + personality routines; the cache will contains only the frame unwinding
> > + instructions associated with the entry (not the descriptors). */
>
> "will contain" or "contains".
Fixed.
> Otherwise, looks good to me.
Thanks for the review, Dan!
Richard, is the patch OK for mainline now?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com