This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Limit attempts to place breakpoints on _start, __start, and main in solib-svr4.c
Hi Kevin,
On Fri, 03 Dec 2010 22:04:33 +0100, Kevin Buettner wrote:
> We do want to (potentially) attempt to place the breakpoints on
> _start, __start, and main in case 1, but not for case 2 and 3.
if this functionality change is enough for now this patch looks safe to me.
> The patch below won't necessarily work correctly with stubs which do
> not implement the qAttached packet. (gdbserver does implement
> qAttached.) My reading of remote.c indicates that stubs which do
> not implement "qAttached" will end up causing attach_flag to be 0.
Therefore it also falls back to the current/safe mode in such case.
> Further comments?
> * solib-svr4.c (enable_break): Don't attempt to place breakpoints,
> when attaching, on the names in bkpt_names: _start, __start, and
> main.
As Mark also agrees with this patch I find it OK for the check-in.
Thanks,
Jan