This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)

From: Tom Tromey <tromey at redhat dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: gdb-patches at sourceware dot org, Joel Brobecker <brobecker at adacore dot com>
Date: Wed, 24 Nov 2010 11:25:01 -0700
Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
References: <1290474834-1945-1-git-send-email-brobecker@adacore.com> <201011231242.44422.pedro@codesourcery.com> <m3lj4k3w1m.fsf@fleche.redhat.com> <201011231628.33851.pedro@codesourcery.com>

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> Here's a patch.  We can move the PyObject fallback typedef from defs.h
Pedro> to varobj.c again.  I haven't looked to see if the PyObject pointers
Pedro> in struct varobj have some other concrete type we could forward
Pedro> declare instead.  Or why don't we #ifdef out those fields if building
Pedro> without python.

Pedro> Tested by building gdb with and without --with-python=no.

Looks good to me.

Tom

References:
- [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
  - From: Joel Brobecker
- Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
  - From: Pedro Alves
- Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
  - From: Tom Tromey
- Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]