This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)

Pedro Alves <pedro@codesourcery.com> writes:

> On Tuesday 23 November 2010 15:21:41, Tom Tromey wrote:
>> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro,


> Here's a patch.  We can move the PyObject fallback typedef from defs.h
> to varobj.c again.  I haven't looked to see if the PyObject pointers
> in struct varobj have some other concrete type we could forward
> declare instead.  Or why don't we #ifdef out those fields if building
> without python.
>
> Tested by building gdb with and without --with-python=no.

I've no objection really, but wouldn't the PyObject typedef be better
suited to defs.h?

Cheers,

Phil
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]