This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] About arm-tdep.c arm_in_function_epilogue_p function
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Richard Earnshaw
> Envoyé?: jeudi 18 novembre 2010 14:56
> À?: Pierre Muller
> Cc?: 'Daniel Jacobowitz'; 'Ulrich Weigand'; gdb-patches@sourceware.org
> Objet?: Re: [RFA] About arm-tdep.c arm_in_function_epilogue_p function
>
>
> On Thu, 2010-11-18 at 14:43 +0100, Pierre Muller wrote:
> > OK, here is the patch.
> >
> > As already said, this patch doesn't change anything on
> > the testsuite results for a armv7l linux machine.
> >
> > > Why don't you just post a patch? Then we can assess it as we would
> all
> > > other patches. The comments in the code at this point clearly
> don't
> > > match the code, so something certainly needs fixing.
> > >
> > > R.
> >
>
> Looking at a wider context I think I see what's happened. The block
> here is essentially a copy of the block earlier in the function with
> s/pc/sp/ applied. Except this one variable wasn't updated properly.
>
> OK.
Thank you for the approval,
patch committed:
http://sourceware.org/ml/gdb-cvs/2010-11/msg00088.html
Pierre