This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Re: Re: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name
- From: Joel Brobecker <brobecker at adacore dot com>
- To: JuYoung Kim <j0 dot kim at samsung dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 17 Nov 2010 11:21:56 -0800
- Subject: Re: Re: Re: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name
- References: <21410336.44431289952805399.JavaMail.weblogic@epml19>
> I have trouble with the cvs server, because my company's firewall
> doesn't allow me to connect it. Instead of me, you or someone can
> commit this patch, I hope.
Checking in the patch for you should be no problem. However,
you still need to submit the patch in a way that helps us review
and then apply it, which means a "diff" file. Instead of using
CVS, I recommend a pure diff between the untouched file and
the new version.
You'll also need to follow the instructions given in the CONTRIBUTE
file as I pointed out (provide a ChangeLog entry, etc), as well as
inform us how you tested the change. Normally, we require that you
run the testsuite before and after, and verify that it does not
introduce any regression.
> My mailer doesn't support the email threading.
> Maybe I'll change my email address.
If you are planning on sending regular contributions, I would recommend
that. Otherwise, I don't think it's worth the effort.
--
Joel