This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Multi-dimensional Fortran arrays issue PR11104


Jan, thanks for taking the time to look through the original patch.

> On 18 October 2010 22:20, Jan Kratochvil wrote:
> 
> multi-dim.tar.bz2 (.exp + .f90) should be submitted as a normal patch,

Done.

> 
> ChangeLog should be submitted as a text, not as patch.
> 

I've included the ChangeLog entries within the patch file as plain text before the start of that patch content, this seems to be what others have done, but I can pull them out if this is not correct.

> There are several minor issues with formatting:
> 	http://www.gnu.org/prep/standards/

I believe that these have all been addressed. If I've still missed anything then please let me know.

> 
> This functionality is implemented by archer-jankratochvil-vla from:
> 	http://sourceware.org/gdb/wiki/ArcherBranchManagement
> 
> (out of bounds access is not detected by the VLA patchset though)
> 
> which is currently not submitted for a review as it has more
> prerequisites.

As I had the patch pretty much ready I cleaned it up anyway. I guess it's up to someone else to decide to merge this or wait for the Archer branch to land.

Thanks,

Andrew



Attachment: arrays.test.patch;size=4232;creation-date="Tue,
Description: arrays.test.patch

Attachment: arrays.patch;size=3113;creation-date="Tue,
Description: arrays.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]