Re: [PATCH] [sparc] inferior SEGV while calling Ada subprogram

[Joel Brobecker <brobecker at adacore dot com>]

> > gdb/ChangeLog:
> > 
> >         * sparc-tdep.c (sparc32_frame_align): New function.
> >         (sparc32_gdbarch_init): Set the frame_align gdbarch method.
> >         * sparc64-tdep.c (sparc64_frame_align): New function.
> >         (sparc64_gdbarch_init): Set the frame_align gdbarch method.
[...]
> Looks ok to me.  However...

Thanks, checked in :).


> > +/* Implement the frame_align gdbarch method.  */
> > +
> 
> That comment is pretty meaningless.  Can you leave it out?

Sure, I removed the comment from the patch that got checked in.
The reason for putting the comment is the fact that we're trying to
have every function documented.  These ones are already documented
by virtue of being one architecture-specific version of a documented
routine. But adding a comment allows us to avoid the question of
what needs to be documented, and what does not...

Thanks again,
-- 
Joel