This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix printing parameters of inlined functions
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Date: Tue, 28 Sep 2010 09:40:45 +0100
- Subject: Re: [patch] Fix printing parameters of inlined functions
- References: <20100927232839.GA22548@host1.dyn.jankratochvil.net>
Looks good to me. One note:
On Tuesday 28 September 2010 00:28:39, Jan Kratochvil wrote:
> ui_out_text (uiout, " (");
> - if (print_args)
> + if (print_args && func != NULL)
I think this changes MI behaviour, but I didn't try it.
It looks like we will print no "args" list at all, while
before it would print an empty "args" list. No sure whether that's
a safe change.
> {
> struct print_args_args args;
> struct cleanup *args_list_chain;
>
> args.frame = frame;
> - args.func = find_pc_function (get_frame_address_in_block (frame));
> + args.func = func;
> args.stream = gdb_stdout;
> args_list_chain = make_cleanup_ui_out_list_begin_end (uiout, "args");
--
Pedro Alves