This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix printing parameters of inlined functions


Looks good to me.  One note:

On Tuesday 28 September 2010 00:28:39, Jan Kratochvil wrote:
>    ui_out_text (uiout, " (");
> -  if (print_args)
> +  if (print_args && func != NULL)

I think this changes MI behaviour, but I didn't try it.
It looks like we will print no "args" list at all, while
before it would print an empty "args" list.  No sure whether that's
a safe change.

>      {
>        struct print_args_args args;
>        struct cleanup *args_list_chain;
>  
>        args.frame = frame;
> -      args.func = find_pc_function (get_frame_address_in_block (frame));
> +      args.func = func;
>        args.stream = gdb_stdout;
>        args_list_chain = make_cleanup_ui_out_list_begin_end (uiout, "args");

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]