This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[rfc 4/5] testsuite: break-interp.exp: Run the common case
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 27 Sep 2010 21:07:38 +0200
- Subject: [rfc 4/5] testsuite: break-interp.exp: Run the common case
Hi,
the testcase was now errorneously excluding the most common case of prelink
usage. With no PIE prelinking the executable prelinks all the shared
libraries, GDB must be able to load them appropriately.
While it is not a too interesting case it is the most common case of prelink
usage. It is unrelated to PIE, though.
Also it increases the already heavy number of combinations break-interp.exp
runs. I am not sure how important is to run this part. The testcase
combination set should be reduced some way anyway. With the change it takes
still "just" 1m56.981s on my host and the testcase is linux-native (but not
x86*) limited anyway.
Thanks,
Jan
gdb/testsuite/
2010-09-27 Jan Kratochvil <jan.kratochvil@redhat.com>
Do not exclude working sstups.
* gdb.base/break-interp.exp <$binprelink == "YES" && $binpie == "NO>:
Remove.
--- a/gdb/testsuite/gdb.base/break-interp.exp
+++ b/gdb/testsuite/gdb.base/break-interp.exp
@@ -601,12 +601,6 @@ foreach ldprelink {NO YES} {
# It cannot be used for problem reproducibility after the
# testcase ends.
foreach binpie {NO YES ATTACH} {
- # This combination is not possible, non-PIE (fixed address)
- # binary cannot be prelinked to any (other) address.
- if {$binprelink == "YES" && $binpie == "NO"} {
- continue
- }
-
set binname "BINprelink${binprelink}debug${binsepdebug}pie${binpie}"
set exec $binprefix-$binname